Add ZstdCompressor to S3 Plugin and Fix Tests According to Maintainer's Feedback #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses the maintainer's feedback regarding the addition of the
ZstdCompressor
to the S3 output plugin.Changes Made:
Removed Duplicate
ZstdCompressor
Class:lib/fluent/plugin/s3_compressor_zstd.rb
as theZstdCompressor
class was already defined inout_s3.rb
, eliminating duplication.Added Tests for
ZstdCompressor
intest_out_s3.rb
:ZstdCompressor
fromtest_in_s3.rb
totest_out_s3.rb
since they pertain to the output plugin.test_configure_with_mime_type_zstd
andtest_write_with_zstd
to verify the proper functioning ofZstdCompressor
.Ensured
ZstdCompressor
is Properly Registered:ZstdCompressor
is correctly registered in theCOMPRESSOR_REGISTRY
withinout_s3.rb
.Fixed Test Failures:
s3path
intest_write_with_zstd
to match the expected file extension for zstd compression, resolving the test failure.Resolved Gem Build Error:
s3_compressor_zstd.rb
from the Git index to fix the gem build error caused by the file being listed but not present.Notes:
Please review the changes, and let me know if any further adjustments are needed.